Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After an upgrade the LDAP server won't start if nsslapd-conntablesize is present in the dse.ldif file #5956

Open
tmihinto opened this issue Oct 17, 2023 · 3 comments
Open

After an upgrade the LDAP server won't start if nsslapd-conntablesize is present in the dse.ldif file #5956

tmihinto opened this issue Oct 17, 2023 · 3 comments
Assignees
@jchapma
Labels
priority_high need urgent fix / highly valuable / easy to fix
Milestone
1.4.3

Comments

@tmihinto
Copy link

Issue Description
After an upgrade of the 389-ds packages, the server won't start and it complains about nsslapd-conntablesize being present in the dse.ldif file.

Package Version and Platform:

  • Platform: RHEL 8.8
  • Package and version: 389-ds-base-1.4.3.35-2.module+el8.8.0+19693+b24f535c.x86_64

Steps to Reproduce
Steps to reproduce the behavior:

  1. Make sure nsslapd-conntablesize is present in the dse.ldif

  2. Upgrade the 389-ds packages ( here I'm using a system with IPA installed )

  3. Attempts to restart the LDAP server will fail.
    For instance:
    ipactl start Starting Directory Service Failed to start Directory Service: CalledProcessError(Command ['/bin/systemctl', 'start', 'dirsrv@<INSTANCE>.service'] returned non-zero exit status 1)

  4. LDAP errors log:
    [17/Oct/2023:14:45:29.422170234 +0200] - ERR - dse_read_one_file - The entry cn=config in file /etc/dirsrv/slapd-<INSTANCE>/dse.ldif (lineno: 17) is invalid, error code 1 (Operations error) - User setting of nsslapd-conntablesize attribute is disabled, server has auto calculated its value to 0.
    [17/Oct/2023:14:45:29.493095110 +0200] - ERR - init_dse_file - Could not load config file [dse.ldif]
    [17/Oct/2023:14:45:29.494808167 +0200] - ERR - setup_internal_backends - Please edit the file to correct the reported problems and then restart the server.

  5. After removing the nsslapd-conntablesize line, the server can be started.

Expected results
Working LDAP server.

Additional context
This can also be reproduced by editing directly the dse.ldif and adding the nsslapd-conntablesize parameter.
@tmihinto tmihinto added the needs triage The issue will be triaged during scrum label Oct 17, 2023
@jchapma jchapma self-assigned this Oct 17, 2023
@tbordaz tbordaz added priority_high need urgent fix / highly valuable / easy to fix and removed needs triage The issue will be triaged during scrum labels Oct 17, 2023
@jchapma jchapma added this to the 1.4.3 milestone Oct 17, 2023
jchapma added a commit to jchapma/389-ds-base that referenced this issue Oct 17, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
8dcf424 
…blesize

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Return LDAP_SUCESS instead...

Related: 389ds#5956

Reviewed by:
@jchapma jchapma mentioned this issue Oct 17, 2023
Merged
jchapma added a commit that referenced this issue Oct 18, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
cddafbc 
…blesize (#5957)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Return LDAP_SUCESS instead...

Related: #5956

Reviewed by: @Firstyear  (Thank you)
jchapma added a commit that referenced this issue Oct 18, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
19db799 
…blesize (#5957)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Return LDAP_SUCESS instead...

Related: #5956

Reviewed by: @Firstyear  (Thank you)
jchapma added a commit that referenced this issue Oct 18, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
0fbb32b 
…blesize (#5957)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Return LDAP_SUCESS instead...

Related: #5956

Reviewed by: @Firstyear  (Thank you)
jchapma added a commit that referenced this issue Oct 18, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
a2dbf9c 
…blesize (#5957)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Return LDAP_SUCESS instead...

Related: #5956

Reviewed by: @Firstyear  (Thank you)
jchapma added a commit that referenced this issue Oct 18, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
3e51635 
…blesize (#5957)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Return LDAP_SUCESS instead...

Related: #5956

Reviewed by: @Firstyear  (Thank you)
jchapma added a commit to jchapma/389-ds-base that referenced this issue Oct 18, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connta…
9936bd6 
…blesize

Description: Add a test case for issue 5956

Related: 389ds#5956

Reviewed by:
@jchapma jchapma mentioned this issue Oct 18, 2023
Merged
jchapma added a commit that referenced this issue Oct 23, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connt…
f7fc689 
…a… …blesize (#5963)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Correct return value

Related: #5956

Reviewed by: @tbordaz @droideck (Thank you)
jchapma added a commit that referenced this issue Oct 24, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connt…
88616cc 
…a… …blesize (#5963)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Correct return value

Related: #5956

Reviewed by: @tbordaz @droideck (Thank you)
jchapma added a commit that referenced this issue Oct 24, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connt…
71aeab3 
…a… …blesize (#5963)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Correct return value

Related: #5956

Reviewed by: @tbordaz @droideck (Thank you)
jchapma added a commit that referenced this issue Oct 24, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connt…
8ac08e9 
…a… …blesize (#5963)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Correct return value

Related: #5956

Reviewed by: @tbordaz @droideck (Thank you)
jchapma added a commit that referenced this issue Oct 24, 2023
@jchapma
Issue 5956 - After an upgrade the server won't start - nsslapd-connt…
8884fcf 
…a… …blesize (#5963)

Description: A commit, that increased the default connection table size included
the deprecation of the attribute nsslapd-conntablesize. An attempt to set the value
of this attribute issued a warning message and returned LDAP_OPERATIONS_ERROR. This
causes an issue after an upgrade, the server fails to start if nsslapd-conntablesize
is present in dse.ldif

Fix: Correct return value

Related: #5956

Reviewed by: @tbordaz @droideck (Thank you)
@jchapma
Copy link
Contributor

jchapma commented Oct 24, 2023

19db799..88616cc 389-ds-base-1.4.4 -> 389-ds-base-1.4.4
0fbb32b..71aeab3 389-ds-base-2.0 -> 389-ds-base-2.0
a2dbf9c..8ac08e9 389-ds-base-2.1 -> 389-ds-base-2.1
f62be25..8884fcf 389-ds-base-2.2 -> 389-ds-base-2.2

@jchapma jchapma closed this as completed Oct 24, 2023
@tbordaz tbordaz reopened this Nov 9, 2023
@tbordaz
Copy link
Contributor

tbordaz commented Nov 9, 2023

@jchapma , regarding that patch on top of 1.4.3, it looks that the test is problematic when conntable_size==0 (slapdFrontendConfig->conntablesize not initialized).
In main, the code just set 'size = maxdesc - reserved'. Do you recall the goal of that test ?

@jchapma
Copy link
Contributor

jchapma commented Feb 19, 2024

@tbordaz Apologies, but I am only seeing this message now. I will chat with you during the week to see if its still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchapma jchapma

Labels
priority_high need urgent fix / highly valuable / easy to fix
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
3 participants
@tbordaz @jchapma @tmihinto