Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - Custom schema object is removed on a failed edit #5966

Closed
droideck opened this issue Oct 20, 2023 · 1 comment · Fixed by #5967
Closed

CLI - Custom schema object is removed on a failed edit #5966

droideck opened this issue Oct 20, 2023 · 1 comment · Fixed by #5967
Labels
needs triage The issue will be triaged during scrum

Comments

@droideck
Copy link
Member

Issue Description
When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object and only then do we add the new one (edited). We should bring the old schema object on the failed attempt.

Steps to Reproduce
Steps to reproduce the behaviour:

  1. Add a new custom schema object (ObjectClass or AttributeTypes)
  2. Make an invalid edit - put "()" in an alias name field.
  3. Save

Actual results
Error is displayed but the old schema object is removed.

Expected results
Error is displayed and the old schema object still exists.
@droideck droideck added the needs triage The issue will be triaged during scrum label Oct 20, 2023
droideck added a commit to droideck/389-ds-base that referenced this issue Oct 20, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit
352668c 
Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: 389ds#5966

Reviewed by: ?
@droideck droideck mentioned this issue Oct 20, 2023
Merged
droideck added a commit that referenced this issue Oct 24, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#…
8e379e2 
…5967)

Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: #5966

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this issue Oct 24, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#…
9a78214 
…5967)

Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: #5966

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this issue Oct 24, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#…
4285cee 
…5967)

Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: #5966

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this issue Oct 24, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#…
64bdd6d 
…5967)

Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: #5966

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this issue Oct 24, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#…
fe7d7df 
…5967)

Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: #5966

Reviewed by: @mreynolds389 (Thanks!)
droideck added a commit that referenced this issue Oct 24, 2023
@droideck
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#…
dc743d0 
…5967)

Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).

Bring the old schema object on the failed attempt.

Resolves: #5966

Reviewed by: @mreynolds389 (Thanks!)
@droideck
Copy link
Member Author

26716f0..9a78214 389-ds-base-2.3 -> 389-ds-base-2.3
3e51635..4285cee 389-ds-base-2.2 -> 389-ds-base-2.2
8ac08e9..64bdd6d 389-ds-base-2.1 -> 389-ds-base-2.1
71aeab3..fe7d7df 389-ds-base-2.0 -> 389-ds-base-2.0
f7fc689..dc743d0 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage The issue will be triaged during scrum
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 5966 - CLI - Custom schema object is removed on a failed edit droideck/389-ds-base
1 participant
@droideck