New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the PassSync build environment #694

Closed

389-ds-bot opened this issue Sep 12, 2020 · 6 comments

Labels

Milestone

389-ds-bot commented Sep 12, 2020

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47357

Created at 2013-05-10 06:44:27 by nhosoi (@nhosoi)
Closed as Fixed
Assigned to nhosoi (@nhosoi)

. Microsoft Visual Studio 2012 Express
. Microsoft Windows SDK v6.1
. Wix Toolset v3.7

389-ds-bot added the closed: fixed label

389-ds-bot added this to the passsync 1.1.5 milestone

Author

389-ds-bot commented Sep 12, 2020

Comment from nhosoi (@nhosoi) at 2013-05-10 06:45:59

git patch file (master)
0001-Update-the-Password-Synchronization-Build-environmen.patch

389-ds-bot closed this as completed

Author

389-ds-bot commented Sep 12, 2020

Comment from rmeggins (@richm) at 2013-05-10 19:34:24

one minor nit

            <ServiceControl Id='PassSyncControll' Name='PassSync' Start='install' Stop='uninstall' Remove='uninstall' Wait='no'/>

should be PassSyncControl

otherwise, looks good.

Author

389-ds-bot commented Sep 12, 2020

Comment from nhosoi (@nhosoi) at 2013-05-10 23:42:17

Thanks for the review, Rich! I fixed the flaw you found.

Author

389-ds-bot commented Sep 12, 2020

Comment from nhosoi (@nhosoi) at 2013-05-10 23:42:45

git patch file (master) -- take 2
0001-Ticket-47357-Update-the-PassSync-build-environment.patch

Author

389-ds-bot commented Sep 12, 2020

Comment from nhosoi (@nhosoi) at 2013-05-10 23:44:11

Pushed to master: commit dee187ccfdcd92c9261a2cd34b47703bb1d69835

Author

389-ds-bot commented Sep 12, 2020

Comment from nhosoi (@nhosoi) at 2017-02-11 23:09:01

Metadata Update from @nhosoi:

Issue assigned to nhosoi
Issue set to the milestone: passsync 1.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment