Issue 2820 - Fix CI tests #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadhikar
force-pushed
the
fix-ticket47973
branch
from
8bd57a3
to
5e4691c
Compare
aadhikar
commented
Oct 8, 2020
| from lib389._constants import TASK_WAIT | ||
| from lib389._constants import DEFAULT_SUFFIX | ||
| from lib389._mapped_object import DSLdapObjects | ||
| from lib389.idm.user import UserAccounts | ||
|
|
||
| pytestmark = pytest.mark.tier1 |
There was a problem hiding this comment.
originally tickets/ticket47973_test.py was under tier2.
aadhikar
commented
Oct 8, 2020
droideck
requested changes
Oct 8, 2020
There was a problem hiding this comment.
The rest looks good to me. But maybe @Firstyear will something to say...
aadhikar
commented
Oct 8, 2020
Bug Description: tickets/ticket47973_test.py test had failures in CI nightly runs Fix Description: Fixed the failure and also changed the code to use DSLdapObject moved the code into the schema test suite. Relates: 389ds#2820 Reviewed by: Simon(droideck)
aadhikar
force-pushed
the
fix-ticket47973
branch
from
5e4691c
to
12943cd
Compare
|
Please, avoid 'git push --force' option as it's hard to follow what changes were made.
|
|
@droideck opps, sure i will keep that in mind. Normal push was giving me some error i guess but sure I will completely avoid it. |
aadhikar
commented
Oct 9, 2020
|
|
||
| # While we wait for the task to complete search for our user | ||
| search_count = 0 | ||
| while search_count < 10: | ||
| # Now check the user is still being returned | ||
| # Check if task is complete | ||
| assert user.exists() | ||
| task_entry = topo.standalone.tasks.entry | ||
| if topo.standalone.tasks.checkTask(task_entry)[0]: | ||
| if task.get_exit_code() == 0: |
There was a problem hiding this comment.
didn't use task.wait() here as the test needs it to be a race condition. Also made changes in other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: tickets/ticket47973_test.py test had failures in CI nightly runs
Fix Description: Fixed the failure and also changed the code to use DSLdapObject
moved the code into the schema test suite.
Relates: #2820
Reviewed by: ??