20201111 chaining db paged search #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note this has been split into two so that the fix can be applied for a customer hotfix. |
droideck
approved these changes
Nov 12, 2020
| pytestmark = pytest.mark.tier1 | ||
|
|
||
| def test_chaining_paged_search(topology): | ||
| """ |
There was a problem hiding this comment.
Test case docstring parser may complain here because there is no text on the first line.
| from lib389.idm.account import Accounts, Account | ||
| from lib389.topologies import topology_i2 as topology | ||
| from lib389.backend import Backends | ||
| from lib389._constants import * |
There was a problem hiding this comment.
Please, avoid mass imports if possible.
Bug Description: This test case shows how a paged search with criticality set to false, causes chaining to sigsegv. Fix Description: N/A - this is a reproducer, not the fix. fixes: 389ds#4428 Author: William Brown <william@blackhats.net.au> Review by: @droideck, @mreynolds389
…chaining Bug Description: When a paged search through chaining backend is received with a false criticality (such as SSSD), chaining backend will sigsegv due to a null context. Fix Description: When a NULL ctx is recieved to be freed, this is as paged results have finished being sent, so we check the NULL ctx and move on. fixes: 389ds#4428 Author: William Brown <william@blackhats.net.au> Review by: @droideck, @mreynolds389
Firstyear
force-pushed
the
20201111-chaining-db-paged-search
branch
from
0961b48
to
db182f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4428 by checking if the context we receive is NULL. This passes the reproduction case, and it also is shown under LSAN not to create any memory leaks or crashes with ASAN.