Issue 4297: 2nd fix for on ADD replication URP issue internal searche… #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack from me, @mreynolds389 probably will want to check too. |
tbordaz
force-pushed
the
issue_4297_2
branch
2 times, most recently
from
0a8c101
to
d902883
Compare
|
@tbordaz - have you had a chance to review my comment? |
Which comment? I don't see it ... |
|
|
||
| char *conflict_csnstr = (char*)slapi_entry_attr_get_ref((Slapi_Entry *)entry, "conflictcsn"); | ||
| CSN *conflict_csn = csn_new_by_string(conflict_csnstr); | ||
| CSN *tombstone_csn = NULL; | ||
|
|
||
| char *filter = slapi_filter_sprintf("(&(objectclass=nstombstone)(nscpentrydn=%s))", escaped_basedn); | ||
| slapi_ch_free((void **)&escaped_basedn); | ||
| char *filter = slapi_filter_sprintf("(&(objectclass=nstombstone)%s)", escaped_filter); |
There was a problem hiding this comment.
Shouldn't the "%s" be surrounded by ( ) ?
There was a problem hiding this comment.
Thanks Mark. This is the magic of slapi_filter_escape_filter_value to add ( ) around the =.
So no better to no surround the "%s" I imagine it could be rejected for invalid filter
…es with filter containing unescaped chars
Bug description:
Previous fix is buggy because slapi_filter_escape_filter_value returns
a escaped filter component not an escaped assertion value.
Fix description:
use the escaped filter component
relates: 389ds#4297
Reviewed by: William Brown
Platforms tested: F31
tbordaz
force-pushed
the
issue_4297_2
branch
from
d902883
to
89e144e
Compare
tbordaz
added a commit
that referenced
this pull request
Nov 25, 2020
…es with filter containing unescaped chars (#4439) Bug description: Previous fix is buggy because slapi_filter_escape_filter_value returns a escaped filter component not an escaped assertion value. Fix description: use the escaped filter component relates: #4297 Reviewed by: William Brown Platforms tested: F31
tbordaz
added a commit
that referenced
this pull request
Nov 25, 2020
…es with filter containing unescaped chars (#4439) Bug description: Previous fix is buggy because slapi_filter_escape_filter_value returns a escaped filter component not an escaped assertion value. Fix description: use the escaped filter component relates: #4297 Reviewed by: William Brown Platforms tested: F31
tbordaz
added a commit
that referenced
this pull request
Nov 25, 2020
…es with filter containing unescaped chars (#4439) Bug description: Previous fix is buggy because slapi_filter_escape_filter_value returns a escaped filter component not an escaped assertion value. Fix description: use the escaped filter component relates: #4297 Reviewed by: William Brown Platforms tested: F31
tbordaz
added a commit
to tbordaz/389-ds-base
that referenced
this pull request
Nov 26, 2020
…es with filter containing unescaped chars (389ds#4439) Bug description: Previous fix is buggy because slapi_filter_escape_filter_value returns a escaped filter component not an escaped assertion value. Fix description: use the escaped filter component relates: 389ds#4297 Reviewed by: William Brown Platforms tested: F31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s with filter containing unescaped chars
Bug description:
Previous fix is buggy because slapi_filter_escape_filter_value returns
a escaped filter component not an escaped assertion value.
Fix description:
use the escaped filter component
relates: #4297
Reviewed by:
Platforms tested: F31