Trace more SASL calls #4510
Trace more SASL calls #4510
Conversation
Add log trace for sasl_server_start() and sasl_server_step() to investigate performance issues with SASL bind. sasl_errstring() perform a simple and fast switch case mapping from error code to const string. See: 389ds#4506 Signed-off-by: Christian Heimes <cheimes@redhat.com>
| rc = sasl_server_step(sasl_conn, | ||
| cred->bv_val, cred->bv_len, | ||
| &sdata, &slen); | ||
| rc = ids_sasl_server_step(pb_conn, cred, &sdata, &slen); |
There was a problem hiding this comment.
Depending on what we want to do here, we could add these in #ifdef DEBUG.
|
This is somewhat off topic and directed at the Dev team, but we have a problem with Trace Function Call logging level. It basically makes the server unusable. The server start up will fail because it times in when this logging level is enabled, and same for other processes. It's been over-used in the source, and I do not what to use that logging level in this PR. @tiran maybe in this case connection logging is the next best choice (SLAPI_LOG_CONNS). For Dev, we either need new logging levels or we need to change/remove some of the current "trace function call" logging statements. They need to be reduced, one way or another... |
|
@mreynolds389 Well, we need to do a lot related to logging in general, but this is a good point for certain. |
|
@tiran if you change the log level from SLAPI_LOG_TRACE to SLAPI_LOG_CONNS you get my ack. @Firstyear I don't think we should #ifdef this. This logging could be useful in customer situations, so it should be available with the standard build. |
| sasl_conn_t *sasl_conn; | ||
|
|
||
| slapi_log_err(SLAPI_LOG_TRACE, "ids_sasl_server_start", "=> (mech=%s)\n", | ||
| mech); |
There was a problem hiding this comment.
I think we should also log the connection ID in the logging (before and after):
slapi_log_err(SLAPI_LOG_CONNS, "ids_sasl_server_start", "=> (conn=%" PRIu64 " mech=%s)\n",
conn->c_connid, mech);
...
slapi_log_err(SLAPI_LOG_CONNS, "ids_sasl_server_start", "<= (conn=%" PRIu64 " rc=%s)\n",
conn->c_connid, sasl_errstring(rc, NULL, NULL));
Add log trace for sasl_server_start() and sasl_server_step() to
investigate performance issues with SASL bind.
See: #4506
Signed-off-by: Christian Heimes cheimes@redhat.com