Issue 4654 Updates to tickets/ticket48234_test.py #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cl_filter_test.py
…cl_filter_test.py
…cl_filter_test.py
…cl_filter_test.py
kimettog
changed the title
kimettog
commented
Feb 26, 2021
kimettog
added
the
work in progress
kimettog
commented
Mar 2, 2021
bsimonova
reviewed
Mar 3, 2021
Bug Description: Update to tickets/ticket48234_test.py which are currently failing and using soon to be obsolete classes Fix Description: Updated tickets/ticket48234_test.py and ported to the suites directory Updated to utilise the DSLDAPObject class methods relates: <The Issue URL> Author: Gilbert Kimetto Reviewed by: ??? IDMDS-1068 Update failing ticket48234_test.py test [INTEROP-4009] CodeReady Studio on OpenShift - Run locally [INTEROP-4009] CodeReady Studio on OpenShift - Run locally [IDMDS-1068] Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py [IDMDS-1068] Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py
Description: If you bind as a user that does not exist. Error 49 is returned
instead of error 32. As error 32 discloses that the entry does
not exist. When you bind as an entry that does not have userpassword
set then error 48 (inappropriate auth) is returned, but this
discloses that the entry does indeed exist. Instead we should
always return error 49, even if the password is not set in the
entry. This way we do not disclose to an attacker if the Bind
DN exists or not.
Relates: #4609
Reviewed by: tbordaz(Thanks!)
Bug Description: Improve the --help page, and finish wiring in some features. Fix Description: Wire in exclusion of attributes/schema for migration. fixes: #4591 Author: William Brown <william@blackhats.net.au> Review by: @mreynolds389, @droideck
Description: This ports all th TreeViews to PF4, and also does some proof
of concept changes for PF3 to PF4 migration. There is much
more needed, but this does not break anything
relates: #4149
Reviewed by: spichugi(Thanks!)
Issue 4564 - RFE - Add suffix to dscontainer rc file Bug Description: The suffix was not added before, adding a hurdle to automatic admin of the container instance Fix Description: If the suffix is set, add it to the created rc file. fixes: #4564 Author: @Jackbennett Review by: @Firstyear
…back-ldbm A massive change (https://directory.fedoraproject.org/docs/389ds/design/backend-redesign-phase3.html) that implements and use the dbimpl API in the backend.
…4614) Description: RHDS instance will fail to start if the TLS server certificate nickname doesn't match the value of the configuration parameter "nsSSLPersonalitySSL". The mismatch typically happens when customers copy the NSS DB from a previous instance or export the certificate's data but forget to set the "nsSSLPersonalitySSL" value accordingly. Log an additional message which should help a user to set up nsSSLPersonalitySSL correctly. Fixes: #4593 Reviewed by: @Firstyear (Thanks!)
Bug Description: When optimizing our mutexes we check for a system called
coherency_line_size that contains the size value, but if
the file did not exist the server would crash in PR_Read
(NULL pointer for fd).
Fix Description: Check PR_Open() was successfully before calling PR_Read().
Relates: #4324
Reviewed by: tbordaz(Thanks!)
… it in back-ldbm (#4618) see design document https://directory.fedoraproject.org/docs/389ds/design/backend-redesign-phase3.html
Desciption: When a connection hits max threads per conn for the first time
log a message in the error. This will help customers diagnosis
misbehaving clients.
Fixes: #4615
Reviewed by: progier389(Thanks!)
Description: Remove the requirement for pytest from lib389, it causes
unneeded package requirements on Fedora/RHEL.
Fixes: #4619
Reviewed by: mreynolds(one line commit rule)
Description: The tests aumme the system is using IPv6 loopback address, but it
should still check for IPv4 loopback.
Relates: #4513
Reviewed by: ?
Description: tickets/ticket48961_test.py was failing in CI nightly runs. Fixed the failure by changing the code to use DSLdapObject and moved the code into the config test suite. Relates: #2820 Reviewed by: droideck (Thanks!)
Description: Ported the charts under the monitor tab to use PF4 sparkline charts
and provide realtime stats on the the caches.
Relates: #4169
Reviewed by: spichugi(Thanks!)
Bug Description: During a paged search with lookthroughlimit enabled, lookthroughcount is used to keep track of how many entries are examined. A paged search reads ahead one entry to catch the end of the search so it doesn't show the prompt when there are no more entries. lookthroughcount doesn't take read ahead into account when tracking how many entries have been examined. Fix Description: Keep lookthroughcount in sync with read ahead by by decrementing it during read ahead roll back. Fixes: #4595 Relates: #4513 Reviewed by: droideck, mreynolds389, Firstyear, progier389 (Many thanks)
Description: Replace all the CustomCollapse components with PF4
ExpandableSection component.
relates: #4169
Reviewed by: spichugi(Thanks!)
[IDMDS-1068] Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py
Description: Migrate the toast notifications to PF4 Alerts.
Also fixed a refresh problem on the Tuning page.
relates: #4169
Reviewed by: spichugi(Thanks!)
Bug description: When an operation is flagged OP_FLAG_NOOP, it skips BETXN plugins but calls POST plugins. For sync_repl, betxn (sync_update_persist_betxn_pre_op) creates an operation extension to be consumed by the post (sync_update_persist_op). In case of OP_FLAG_NOOP, there is no operation extension. Fix description: Test that the operation is OP_FLAG_NOOP if the operation extension is missing relates: #4649 Reviewed by: William Brown (thanks) Platforms tested: F31
…the changelog (#4647) Bug description: The replication agreements are using bulk load to load updates. For bulk load it uses a cursor with DB_MULTIPLE_KEY and DB_NEXT. Before using the cursor, it must be initialized with DB_SET. If during the cursor/DB_SET the CSN refers to an update that is larger than the size of the provided buffer, then the cursor remains not initialized and c_get returns DB_BUFFER_SMALL. The consequence is that the next c_get(DB_MULTIPLE_KEY and DB_NEXT) will return the first record in the changelog DB. This break CLcache. Fix description: The fix is to harden cursor initialization so that if DB_SET fails because of DB_BUFFER_SMALL. It reallocates buf_data and retries a DB_SET. If DB_SET can not be initialized it logs a warning. The patch also changes the behaviour of the fix #4492. #4492 detected a massive (1day) jump prior the starting csn and ended the replication session. If the jump was systematic, for example if the CLcache got broken because of a too large updates, then replication was systematically stopped. This patch suppress the systematically stop, letting RA doing a big jump. From #4492 only remains the warning. relates: #4644 Reviewed by: Pierre Rogier (Thanks !!!!) Platforms tested: F31
Bug Description: There was a false assumption that you have to create the shared DNA server configuration entry, but in fact the server creates and manages this entry. The only thing you should edit in this entry are the remote Bind Method and Connection Protocol. Fix Description: Remove the options to create the shared config entry, and edit the core/reserved attributes. Also fixed some issues where we were not showing CLI plugin output in proper JSON. This required some changes to the UI as well. Relates: #4646 Reviewed by: spichugi(Thanks!) [IDMDS-1068] Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py [IDMDS-1068] Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py
…le (#4645) Description: The Fedora builds of 389-DS uses the vendored crates to build the official packages for Rawhide. Vendoring and bundling dependencies is in violation of Fedora policies. As an upstream project we are free to ship vendored code. But as a downstream Fedora project we must not use the vendored code. Add a tool that will help to generate 'Provides: bundled(crate(foo)) = version' for Cargo.lock file content. Replace License field which should contain all of the package licenses we bundle in the specfile. Fixes: #4643 Reviewed by: @Firstyear, @decathorpe, @mreynolds389 (Thanks!)
…in (#4622) * issue 4552 - Backup Redesign phase 3b - use dbimpl in replicatin plugin Merge of a fix in cl5_clcache.c (changelog cache restarts from begining if large update) Rebase with master * Issue 4469 - Backend redesing phase 3a - implement dbimpl API and use it in back-ldbm - fix test_maxbersize_repl pytest failure * issue 4552 - Backup Redesign phase 3b - use dbimpl in replicatin plugin - fix indent issue * issue 4552 - Backup Redesign phase 3b - use dbimpl in replicatin plugin - fix merge issue manual Merge of fix about changelog cache iteration restarting from beginning in case of large update + automatic rebase to master * Issue 4552 - Backend redesign phase 3b - fix indent issue + random crash and memory leak in tombstone handling
Issue 4663 - CLI - unable to add objectclass/attribute without x-origin Issue 4654 Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py
kimettog
removed
the
work in progress
droideck
approved these changes
Mar 15, 2021
…cl_filter_test.py Bug Description: - Update ticket48234_test.py to verify tests on RHEL 7/8 and Fedora - Update deprecated "*_s" methods to leverage the DSLDAPObject class - Move test from the current location in ../tickets to appropriate ../suites/aci/* directory Fix Description: - Issue 4654 Update ticket48234_test.py and move to suites/acl/aci_excl_filter_test.py relates: Author: Gilbert Kimetto Reviewed by: ???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IDMDS-1068] Update ticket48234_test.py rename and move to --> suites/acl/aci_excl_filter_test.py
- Update to use DSLdapObject class