Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4169 - UI - migrate replication tables to PF4 #4722

Merged
merged 1 commit into from Apr 16, 2021
Merged

Issue 4169 - UI - migrate replication tables to PF4 #4722

merged 1 commit into from Apr 16, 2021

Conversation

mreynolds389
Copy link
Contributor

Description:

Migrated replication tables to PF 4 and cleaned up replication monitoring.

relates: #4169

jchapma
jchapma reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@jchapma jchapma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

droideck
droideck approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ack

P.S. yeah, we really should thing about replacing Repl Monitor tabs report... I'll try to think more about this UI/UX solution...

@mreynolds389
Copy link
Contributor Author

Looks great! Ack

P.S. yeah, we really should thing about replacing Repl Monitor tabs report... I'll try to think more about this UI/UX solution...

Yeah, it's not terrible but could be better.

In fact, if you noticed I took the repl and winsync agreements out of the monitor completely. You can't get the status or lag time without the credentials so it's not really useful, so it's gone -> meaning we only have the "Sync Report" left.

@droideck
Copy link
Member

Looks great! Ack
P.S. yeah, we really should thing about replacing Repl Monitor tabs report... I'll try to think more about this UI/UX solution...

Yeah, it's not terrible but could be better.

In fact, if you noticed I took the repl and winsync agreements out of the monitor completely. You can't get the status or lag time without the credentials so it's not really useful, so it's gone -> meaning we only have the "Sync Report" left.

Sounds good to me:) No objections on my side.

@mreynolds389
Issue 4169 - UI - migrate replication tables to PF4
6f3154f 
Description:  Migrated replication tables to PF 4 and cleaned up
              replication monitoring.

relates: 389ds#4169

Reviewed by: spichugi & jchapman(Thanks!!)
@mreynolds389 mreynolds389 merged commit a67fa12 into 389ds:master Apr 16, 2021
@mreynolds389 mreynolds389 deleted the PR4-repl-tables branch April 16, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchapma jchapma jchapma left review comments

@droideck droideck droideck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mreynolds389 @droideck @jchapma