Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5135 - UI - Disk monitoring threshold does update properly #5136

Merged
merged 1 commit into from Jan 25, 2022

Conversation

mreynolds389
Copy link
Contributor

Description:

If you try entering a value manually and start with an empty field
it overwrites the value with 4096 as it's trying to incorrectly
enforce a minimum value.

relates: #5135

Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the minor issue, looks good to me!

Description:

If you try entering a value manually and start with an empty field
it overwrites the value with 4096 as it's trying to incorrectly
enforce a minimum value.

relates: 389ds#5135

Reviewed by: spichugi(Thanks!)
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ack

@mreynolds389 mreynolds389 merged commit f837841 into 389ds:master Jan 25, 2022
@mreynolds389 mreynolds389 deleted the ui_disk_mon branch January 25, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants