Issue 5184 - memberOf does not work correctly with multiple include scopes #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbordaz
reviewed
Mar 1, 2022
| } | ||
| if (!all_backends) { | ||
| goto done; | ||
| } |
There was a problem hiding this comment.
in case 'all_backend'==True, is there a risk that it goes to the internal search below (line 836). In such case is base_sdn valid and is it processing the base_sdn twice ?
There was a problem hiding this comment.
This function is actually rather confusing. I've revised it again, and it passes CI tests, but please review...
There was a problem hiding this comment.
@tbordaz could you review this again? Remember there is second part to this that is waiting for this to be merged first.
mreynolds389
force-pushed
the
memberof_fix_include_scope
branch
from
eb5611d
to
0e3cc34
Compare
…copes Bug Description: MemberOf Plugin only looks at the first include scope, and the rest are ignored. So if multiple "memberOfEntryScope" attributes are set then the plugin will not work as expected. Fix Description: The fix is to read all the memberOfEntryScope attributes and update the group cache. relates: 389ds#5184 Reviewed by: tbordaz(Thanks!)
mreynolds389
force-pushed
the
memberof_fix_include_scope
branch
from
0e3cc34
to
0af29fe
Compare
|
can you add a test for a "broken" case like |
tbordaz
reviewed
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
MemberOf Plugin only looks at the first include scope, and the rest are
ignored. So if multiple "memberOfEntryScope" attributes are set then the
plugin will not work as expected.
Fix Description:
The fix is to read all the memberOfEntryScope attributes and update the
group cache.
relates: #5184