Issue 5521 - UI - Update plugins for new split PAM and LDAP pass thru auth #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Hmm, something is missing...
I get an error on the build time:
ERROR in ./src/plugins.jsx 37:0-73
Module not found: Error: Can't resolve './lib/plugins/pamPassThru.jsx' in '/__w/389-ds-base/389-ds-base/src/cockpit/389-console/src'
webpack compiled with 1 error
make[1]: Leaving directory '/__w/389-ds-base/389-ds-base/src/cockpit/389-console'
make[1]: *** [node_modules.mk:8: build-cockpit-plugin] Error 1
touch: cannot touch 'cockpit_dist/*': No such file or directory
make: *** [rpm.mk:62: dist-bz2] Error 1
mreynolds389
force-pushed
the
ui-pam-passthru
branch
from
6168a40
to
1123bc6
Compare
Forget to commit the file, fixed now. |
|
Looks good! Screencast.from.01-04-2023.10.59.29.AM.webm |
mreynolds389
force-pushed
the
ui-pam-passthru
branch
from
1123bc6
to
d1037b8
Compare
Fixed |
mreynolds389
force-pushed
the
ui-pam-passthru
branch
from
d1037b8
to
0ffa889
Compare
… auth Description: Previously PAM and LDAP pass thru auth plugins were merged. This change separates them into their own plugins in the UI. Also improved memory reporting in monitor tab. relates: 389ds#5521 Reviewed by: spichugi(Thanks!)
mreynolds389
force-pushed
the
ui-pam-passthru
branch
from
0ffa889
to
35f2f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Previously PAM and LDAP pass thru auth were merged. This changes separates them.
relates: #5521