Issue 5804 - dtablesize being set to soft maxfiledescriptor limit #5806
Conversation
Bug Description: 389ds is not setting dtablesize properly based when systemd is setting the maxfiledescriptors with it's default settings. dtablesize stays 1024 which causes massive slowdown once you hit around 950 connection Fix Description: dtablesize is set to the connection table size, this commit sets the connection table size/dtablesize to the system max file descriptor number less the reserve file descriptors. relates: 389ds#5804 Reviewed by: ?
There was a problem hiding this comment.
The change looks good with a minor comment.
A remark, I would appreciate that the fix description states that 'conntablesize' field disappear from the config entry (both cn=config and internal struct). Also do you know the explanation why there is a big slowdown when the nb of established connection is close to the limit ?
This commit is a backport to 1.4.3 of a subset of the functionality of #5472 that addresses an issue where the default connectiontable size was set too low by default (1024) and the server failed to accept connections when the connection count was ~950. The bits that were backported were the reserve descriptor calculation based on the servers needs and the auto calculation of the connectiontable size. (conntablesize = max_descriptors - reserve descriptors). I just copied the commit description from the https://bugzilla.redhat.com/show_bug.cgi?id=2210491, but I can amend this commits description if you like. |
Im guessing that when the server is getting low on file descriptors there might be some kind of system latency causing this, maybe... |
|
I filed a Bugzilla with Red Hat on this issue: Basically once you hit around 950 connections the entire system just slows completely down. So any large enviroment this causes 389ds to slow way to the point of taking up to 1 minute to return a query. By using work around to that sets the softlimit to the limit. Things work fine. |
|
nsslapd-conntablesize attribute has been added back, setting of this attr is disabled and a warning message returned to the user. The user can still "get" the value of this attr, so rather than return a attr value of 0, I set it in the when the connection table is being created. |
jchapma
force-pushed
the
1.4.3-dtablesize
branch
from
174c75c
to
a7025bd
Compare
Im not sure why this commit didnt have any branch, i reset head and pushed again. |
) Bug Description: 389ds is not setting dtablesize properly based when systemd is setting the maxfiledescriptors with it's default settings. dtablesize stays 1024 which causes massive slowdown once you hit around 950 connection Fix Description: dtablesize is set to the connection table size, this commit sets the connection table size/dtablesize to the system max file descriptor number less the reserve file descriptors. relates: #5804 Reviewed by: @tbordaz @progier389 (Thank you)
) Bug Description: 389ds is not setting dtablesize properly based when systemd is setting the maxfiledescriptors with it's default settings. dtablesize stays 1024 which causes massive slowdown once you hit around 950 connection Fix Description: dtablesize is set to the connection table size, this commit sets the connection table size/dtablesize to the system max file descriptor number less the reserve file descriptors. relates: #5804 Reviewed by: @tbordaz @progier389 (Thank you)
) Bug Description: 389ds is not setting dtablesize properly based when systemd is setting the maxfiledescriptors with it's default settings. dtablesize stays 1024 which causes massive slowdown once you hit around 950 connection Fix Description: dtablesize is set to the connection table size, this commit sets the connection table size/dtablesize to the system max file descriptor number less the reserve file descriptors. relates: #5804 Reviewed by: @tbordaz @progier389 (Thank you)
) Bug Description: 389ds is not setting dtablesize properly based when systemd is setting the maxfiledescriptors with it's default settings. dtablesize stays 1024 which causes massive slowdown once you hit around 950 connection Fix Description: dtablesize is set to the connection table size, this commit sets the connection table size/dtablesize to the system max file descriptor number less the reserve file descriptors. relates: #5804 Reviewed by: @tbordaz @progier389 (Thank you)
Bug Description: 389ds is not setting dtablesize properly based when systemd is setting the maxfiledescriptors with it's default settings. dtablesize stays 1024 which causes massive slowdown once you hit around 950 connection
Fix Description: dtablesize is set to the connection table size, this commit sets the connection table size/dtablesize to the system max file descriptor number less the reserve file descriptors.
relates: #5804
Reviewed by: ?