Rearrange includes for 32-bit support logic #6089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vashirov
force-pushed
the
32bit-support
branch
from
1256797
to
adc062f
Compare
vashirov
approved these changes
Feb 13, 2024
Description: The logic to support 32-bit architectures was correctly written (define _LARGEFILE64_SOURCE) but placed too "late". If a standard library header (e.g., <stdio.h>) is included before _LARGEFILE64_SOURCE is defined, then the correct symbols will not be made available during compliation. In this instance, armhf builds were failing due to off64_t not getting defined correctly. The inclusion of <sys/statvfs.h> in slap.h is required to prevent a cryptic compliation error on "#define f_type f_un.f_un_type". Relates: 389ds#5962 Relates: https://bugs.launchpad.net/ubuntu/+source/389-ds-base/+bug/2052578 Relates: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063434 Reviewed by: @vashirov
vashirov
force-pushed
the
32bit-support
branch
from
adc062f
to
193dc71
Compare
|
@Chris-Peterson444, thank you for your contribution! |
|
Apologies for not linking the downstream bugs and thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to support 32-bit architectures was correctly written (define _LARGEFILE64_SOURCE) but placed too "late". If a standard library header (e.g., <stdio.h>) is included before _LARGEFILE64_SOURCE is defined, then the correct symbols will not be made available during compliation. In this instance, armhf builds were failing due to off64_t not getting defined correctly.
The inclusion of <sys/statvfs.h> in slap.h is required to prevent a cryptic compliation error on "#define f_type f_un.f_un_type". The following bug is possibly related:
#5962