Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building AUR package fails #36

Open
java-py-c-cpp-js opened this issue Nov 26, 2020 · 11 comments
Open

Building AUR package fails #36

java-py-c-cpp-js opened this issue Nov 26, 2020 · 11 comments

Comments

@java-py-c-cpp-js
Copy link

When building evolution-decsync package, the following error message occurs:

The Meson build system
Version: 0.56.0
Source dir: /tmp/pamac-build/evolution-decsync/src/Evolution-DecSync
Build dir: /tmp/pamac-build/evolution-decsync/src/Evolution-DecSync/build
Build type: native build
Project name: evolution-decsync
Project version: 1.2.0
Using 'CFLAGS' from environment with value: '-march=x86-64 -mtune=generic -O2 -pipe -fno-plt'
Using 'LDFLAGS' from environment with value: '-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
Using 'CPPFLAGS' from environment with value: '-D_FORTIFY_SOURCE=2'
C compiler for the host machine: cc (gcc 10.2.0 "cc (GCC) 10.2.0")
C linker for the host machine: cc ld.bfd 2.35.1
Using 'CFLAGS' from environment with value: '-march=x86-64 -mtune=generic -O2 -pipe -fno-plt'
Using 'LDFLAGS' from environment with value: '-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
Using 'CPPFLAGS' from environment with value: '-D_FORTIFY_SOURCE=2'
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (1.7.3)
Run-time dependency libedata-book-1.2 found: YES 3.38.1
Run-time dependency libedata-cal-2.0 found: YES 3.38.1
Run-time dependency evolution-shell-3.0 found: YES 3.38.1
Run-time dependency json-c found: YES 0.15
Found CMake: /usr/bin/cmake (3.18.4)
Run-time dependency decsync found: NO (tried pkgconfig and cmake)

meson.build:13:0: ERROR: Dependency "decsync" not found, tried pkgconfig and cmake
@java-py-c-cpp-js
Copy link
Author

This error message also happens then I build it manually.

@39aldo39
Copy link
Owner

You also have to install libdecsync. You can do that from source, but there is also an AUR package available. Maybe @vasket can update the dependencies in the AUR package? Basically, the dependencies libgee, json-glib and vala can be removed, and json-c and libdecsync have to be added. If they don't want to maintain it anymore, please let us know. Then we can figure something out, although I am not that familiar with AUR.

@FabioLolix
Copy link

Hello, I have seen the AUR pkgbuild of evolution-decsync and it is poorly made, I am familiar with the AUR and I can fix it (I have made an 'orphan request' meanwhile) but I'm not using either Evolution and DecSync so I'm not interested in long term maintainance

@FabioLolix
Copy link

I have got the pkgbuild and updated it

@theotheroracle
Copy link

theotheroracle commented Aug 3, 2021

ok so it's not currently working, but i don't think it's for the same reason, since libdecsync is installed as a depencency

FAILED: src/modules/cal-config/module-cal-config-decsync.so.p/.._utils_decsync.c.o 
cc -Isrc/modules/cal-config/module-cal-config-decsync.so.p -Isrc/modules/cal-config -I../src/modules/cal-config -Isrc/modules -I../src/modules -Isrc -I../src -I. -I.. -I/usr/include/json-c -I/usr/include/evolution-data-server -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libsecret-1 -I/usr/include/gio-unix-2.0 -I/usr/include/libxml2 -I/usr/include/libsoup-2.4 -I/usr/include/nss -I/usr/include/nspr -I/usr/include/evolution -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/lzo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/webkitgtk-4.0 -I/usr/include/gnome-desktop-3.0 -I/usr/include/gsettings-desktop-schemas -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fPIC -pthread -MD -MQ src/modules/cal-config/module-cal-config-decsync.so.p/.._utils_decsync.c.o -MF src/modules/cal-config/module-cal-config-decsync.so.p/.._utils_decsync.c.o.d -o src/modules/cal-config/module-cal-config-decsync.so.p/.._utils_decsync.c.o -c ../src/modules/utils/decsync.c
In file included from /usr/include/evolution-data-server/libedataserver/libedataserver.h:32,
                 from ../src/e-source/e-source-decsync.h:22,
                 from ../src/modules/utils/decsync.h:20,
                 from ../src/modules/utils/decsync.c:19:
/usr/include/evolution-data-server/libedataserver/e-flag.h:54:50: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
   54 |                                                  GTimeVal *abs_time);
      |                                                  ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/evolution-data-server/libedataserver/e-cancellable-locks.h:31,
                 from /usr/include/evolution-data-server/libedataserver/libedataserver.h:23,
                 from ../src/e-source/e-source-decsync.h:22,
                 from ../src/modules/utils/decsync.h:20,
                 from ../src/modules/utils/decsync.c:19:
/usr/include/glib-2.0/glib/gtypes.h:547:8: note: declared here
  547 | struct _GTimeVal
      |        ^~~~~~~~~
../src/modules/utils/decsync.c: In function ‘config_decsync_update_combo_box’:
../src/modules/utils/decsync.c:178:25: error: format not a string literal and no format arguments [-Werror=format-security]
  178 |                         error_string);
      |                         ^~~~~~~~~~~~
cc1: some warnings being treated as errors
[17/19] Compiling C object src/modules/book-config/module-book-config-decsync.so.p/.._utils_decsync.c.o
FAILED: src/modules/book-config/module-book-config-decsync.so.p/.._utils_decsync.c.o 
cc -Isrc/modules/book-config/module-book-config-decsync.so.p -Isrc/modules/book-config -I../src/modules/book-config -Isrc/modules -I../src/modules -Isrc -I../src -I. -I.. -I/usr/include/json-c -I/usr/include/evolution-data-server -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libsecret-1 -I/usr/include/gio-unix-2.0 -I/usr/include/libxml2 -I/usr/include/libsoup-2.4 -I/usr/include/nss -I/usr/include/nspr -I/usr/include/evolution -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/lzo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/webkitgtk-4.0 -I/usr/include/gnome-desktop-3.0 -I/usr/include/gsettings-desktop-schemas -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fPIC -pthread -MD -MQ src/modules/book-config/module-book-config-decsync.so.p/.._utils_decsync.c.o -MF src/modules/book-config/module-book-config-decsync.so.p/.._utils_decsync.c.o.d -o src/modules/book-config/module-book-config-decsync.so.p/.._utils_decsync.c.o -c ../src/modules/utils/decsync.c
In file included from /usr/include/evolution-data-server/libedataserver/libedataserver.h:32,
                 from ../src/e-source/e-source-decsync.h:22,
                 from ../src/modules/utils/decsync.h:20,
                 from ../src/modules/utils/decsync.c:19:
/usr/include/evolution-data-server/libedataserver/e-flag.h:54:50: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
   54 |                                                  GTimeVal *abs_time);
      |                                                  ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/evolution-data-server/libedataserver/e-cancellable-locks.h:31,
                 from /usr/include/evolution-data-server/libedataserver/libedataserver.h:23,
                 from ../src/e-source/e-source-decsync.h:22,
                 from ../src/modules/utils/decsync.h:20,
                 from ../src/modules/utils/decsync.c:19:
/usr/include/glib-2.0/glib/gtypes.h:547:8: note: declared here
  547 | struct _GTimeVal
      |        ^~~~~~~~~
../src/modules/utils/decsync.c: In function ‘config_decsync_update_combo_box’:
../src/modules/utils/decsync.c:178:25: error: format not a string literal and no format arguments [-Werror=format-security]
  178 |                         error_string);
      |                         ^~~~~~~~~~~~
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...
Build failed with exit code 4 in /home/bit/.cache/rua/build/evolution-decsync

should i make a new issue ?

EDIT: i think this is an issue with the aur package actually

@kannes
Copy link

kannes commented Aug 11, 2021

That is because on Arch /etc/makepkg.conf includes -Werror=format-security in the CFLAGS. It would be nice if the warning was fixed in the plugin, I guess it is a potential security issue?

You can add this (default minus that Werror) in your PKGBUILD inside in the build function:

CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
        -Wp,-D_FORTIFY_SOURCE=2 -Wformat \
        -fstack-clash-protection -fcf-protection"

@FabioLolix
Copy link

Don't have time for this pkgbuild anymore, it has been orphaned and is up for grab

@theotheroracle
Copy link

alright, i'll work on it in a bit

39aldo39 added a commit that referenced this issue Oct 23, 2021
@flortsch
Copy link

flortsch commented Dec 7, 2021

I took over the AUR package and updated it to 2.0.0, with the format string commit included as patch so that the package builds.

@theotheroracle
Copy link

awesome

@flortsch
Copy link

This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants