This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Fix UI issues entity panel #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Algorush
commented
May 21, 2024
Algorush
commented
- Made the first Layers tab open when opening the panel instead of blank.
- Attached the close button to the top of the panel when scroll.
- close the panel when switching to Viewer if panel was opened, this does not happen before.
|
Looks good. We won't merge it in this repo though. You will need to redo the PR on 3dstreet repo once 3DStreet/3dstreet#517 is merged, it should be really soon. The src/editor directory there is the same as src directory here. |
|
3DStreet/3dstreet#517 was merged. |
|
Created PR in 3DStreet repo: 3DStreet/3dstreet#528 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.