Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about camera normalize? #42

Open
lulongfei-luffy opened this issue Mar 21, 2024 · 2 comments
Open

about camera normalize? #42

lulongfei-luffy opened this issue Mar 21, 2024 · 2 comments

Comments

@lulongfei-luffy
Copy link

Halo, thank you for sharing your great work.
I see the camera normalization in your code, the camera radius is set to a fixed 1.5,
https://github.com/3DTopia/LGM/blob/main/core/provider_objaverse.py#L127

However, the camera radius in my dataset is randomly selected in the range of [1.4, 1.6]. I wonder whether I can use your code to normalize cameras for my dataset. If not, what should I change the code for my dataset?
Thank you very much.

@ashawkey
Copy link
Collaborator

@lulongfei-luffy Hi, if for each object all the images have the same radius (although it's random among different objects), you can still use the current normalization. However, if the images for the same object have different radius, it's wrong to normalize to the same 1.5 value. In the latter case, you may consider only scaling the radius of the first view's camera to 1.5 (while other views are scaled by the same factor), and then rotate them.

@Gynjn
Copy link

Gynjn commented May 7, 2024

@ashawkey you mean rotate the other views w.r.t the first view?

More precisely, scale all view w.r.t the first view scale (the scale value to make the first view cam position to 1.5), then the radius becomes (1.5 = first view radius / scale, xx / scale, xx / scale ...). And make poses relative to first view.

And normalization is not necessary..? right?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants