Feature/add basic trinkets #32
Conversation
Also, somehow the line endings in Character.cs got changed somehow. Forgive me Father for I have sinned.
| @@ -1,137 +1,171 @@ | |||
| using Assets.Scripts.Moves; | |||
There was a problem hiding this comment.
Did this file change or did git just die
There was a problem hiding this comment.
I mean, yes, it was git's fault
There was a problem hiding this comment.
And also, yes, the file was actually changed
| @@ -1410,7 +1410,7 @@ PrefabInstance: | |||
| - target: {fileID: 2609417324641571755, guid: b049de0ed9494334c9222c97e396c52f, | |||
| type: 3} | |||
| propertyPath: m_Name | |||
| value: Character | |||
| value: Dummy | |||
There was a problem hiding this comment.
| private readonly MockInputBuffer inputBuffer; | ||
|
|
||
| public override string Name => "Shin Splitter"; | ||
| public override string Description => "Stop it! That kind of hurts!"; |
| { | ||
| public abstract class MoveTrinket : TrinketBase | ||
| { | ||
| private readonly Events.EventHandler handler; |
There was a problem hiding this comment.
I feel like this should be
using Events;
EventHandler handler;
There was a problem hiding this comment.
Does github not allow you to make tasks on pull requests? I'm seriously considering moving this project to bitbucket
| private readonly MockInputBuffer inputBuffer; | ||
|
|
||
| public override string Name => "Fist of the North Star"; | ||
| public override string Description => "Omae wa mou shindeiru"; |
| private Character owner; | ||
|
|
||
| public override string Name => "Frailty of Man"; | ||
| public override string Description => "People die when they are killed."; |
There was a problem hiding this comment.
Just because you're correct doesn't mean you're right
There was a problem hiding this comment.
Just wait until we add the trinket that says "You don't die when you are killed"
|
|
||
| public override void onEvent(UpdateEvent e) | ||
| { | ||
| if (trinket.owner.CurrentMove == null) |
There was a problem hiding this comment.
Is this checking that there isn't already a move in progress before trying to kick off the next triggered move?
There was a problem hiding this comment.
Yup, otherwise you can end up with multiple moves queued that will be done in rapid succession
There was a problem hiding this comment.
Other than changing Events.EventHandler to EventHandler with a using directive, looks good! If you have time to answer my other questions that'd be great too.
Hmm, I don't see a way to directly reply to this comment. Fortunately I can just edit it directly! Let me know if you want to go over these changes in a call, it will probably be faster if you have any followup questions.
This change was made to avoid ambigious uses (see System.EventHandler). While this could be addressed through aliasing, it seems like renaming it will be easier in the long run.
No description provided.