Add configuration option for writing enum variants as strings #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure why this code was here, which is why I'm glad we have pull requests for reviewing. It limited enum variants to u32, though, so this allows it to now decode encoded string variants successfully.
kornelski
approved these changes
Sep 1, 2019
|
For c-style enums this serializes quite poorly. enum Foo {
A,
B,
C
}Resulting msgpack is It generally seems like rmp's output cannot really be consumed from other languages. |
|
Yeah, it'd be good to optimize it for fieldless enums. |
|
I think it should be fairly easy for us to adopt the same approach if we also modify the deserializer to accept this form of enum. Edit: opened #225. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this after #207 was merged.
Adds a config option for encoding enums variant names as strings. Does not change any defaults.
Notably, this does not change
rmp_serde::to_vec_named. That remains encoding struct fields names as strings, but enum variants as integers.Fixes #172. Supersedes and closes #154.