NOT NULL in triggers/functions

[BranislavBajuzik]

Hello.

I am using this tool to lint my Postgres migrations (definitely prevented several headaches on deploy) and I found a false-positive:

BEGIN;
-- Create trigger api_user_update on model user
            CREATE OR REPLACE FUNCTION "public"._pgtrigger_should_ignore(
                trigger_name NAME
            )
            RETURNS BOOLEAN AS $$
                DECLARE
                    _pgtrigger_ignore TEXT[];
                BEGIN
                    IF _pgtrigger_ignore IS NOT NULL THEN
                        SELECT trigger_name = ANY(_pgtrigger_ignore)
                 -- And so on
COMMIT;

The migration/sql is courtesy of django-pgtrigger.

This gets flagged because of the if statement, which I think should not trip up the detection. It gets flagged here:

django-migration-linter/django_migration_linter/sql_analyser/base.py

Line 43 in 3503367

re.search("(?<!DROP )NOT NULL", sql)

Some of my hand-written migrations also get flagged for this reason.

If I also may, I suggest that the .startswith() checks should be .strip().lower().startswith() to deal with possible future regressions because of indented/hand-written migrations

[David-Wobrock]

Hey @BranislavBajuzik

Thanks for taking interesting in the library 🙏

Indeed, the checks are a bit raw sometimes. Feel free to suggest a PR! 😄
Else I can try to find some times in the next weeks/months

[kekekekule]

@BranislavBajuzik @David-Wobrock I've suggested a PR here: #273

[David-Wobrock]

Addressed in #282.