-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow #47
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/3b1b/3blue1brown-website/5PbFftCocPd1PjvaSNqkG8ALKEBn |
The current branch variable needs to be made available for creating Git LFS URLs in the staging environment. @3b1b Assuming Vercel works like the environment that runs the github action, try updating Vercel's build command to something like this:
There may be another way to get the current branch name in Vercel, but as long as
Edit: If the above doesn't work, this preview variable might do the trick. |
The |
Do you want to delete the test figure component, and put the real one into effect in this PR. I believe a clean way to do it would be to make
Then in |
✔️ Deploy Preview for 3blue1brown ready! 🔨 Explore the source changes: 72d1727 🔍 Inspect the deploy log: https://app.netlify.com/sites/3blue1brown/deploys/60b0269f597dbc57799fdcd5 😎 Browse the preview: https://deploy-preview-47--3blue1brown.netlify.app |
* Setup git lfs file types and created test post. * Fixed/updated git LFS URLs * Testing modified file and fixing path * Changed order of git lfs url for example * Created test sync action * Fixed bad find replace to correct variable names * Added step and flag to download git lfs objects * Set acl to public, testing workflow * Updated bad flag, testing workflow * Testing sync workflow * Fix typo, testing sync workflow * Added test figure and updated URL paths for example post * Test delete file and new Ubuntu version * Added flag to delete unused files. Testing workflow action. * Updated example * Adds mug animation * Changed old workflow to be consistent * Testing workflow, dry run * Changed bucket variable name * Changed include patterns to lessons directory. Testing workflow, dry run * Modified test date page date to not be a future date. Testing workflow. * updated gitattributes * updated gitattributes, testing workflow * Testing workflow: delete asset * Testing workflow: delete asset * Added production config site parameters, testing branch environment variable * Added parameter to test workflow * Testing workflow with example shortcode * Fixed gitattributes paths * Testing workflow, updated staging paths * Test of git-lfs * Deleted file that should have been tracked with git LFS * Fixed bad path. * Changed action to sync bucket on push to main and to prep for vercel deploy * Added text and image to essence of calculus * Added netlify config file * Changed boolean to string * Pushing arbitrary change to test netlify * Testing netlify preview * Testing netlify preview * Added netlify file config to test CLI * Modified figure shortcode to be aware of page bundle resources. * Test push, added snippets, calculus lesson 1 assets Co-authored-by: Grant Sanderson <grant@3blue1brown.com> Co-authored-by: Josh Pullen <hello@joshuapullen.com> Former-commit-id: 730507cf933e81a52313b7067a47b1f84b5fc339 [formerly 4797018] Former-commit-id: c24f93bc0c866f6e0f99b5ff05bcf5c7710a3766
* Setup git lfs file types and created test post. * Fixed/updated git LFS URLs * Testing modified file and fixing path * Changed order of git lfs url for example * Created test sync action * Fixed bad find replace to correct variable names * Added step and flag to download git lfs objects * Set acl to public, testing workflow * Updated bad flag, testing workflow * Testing sync workflow * Fix typo, testing sync workflow * Added test figure and updated URL paths for example post * Test delete file and new Ubuntu version * Added flag to delete unused files. Testing workflow action. * Updated example * Adds mug animation * Changed old workflow to be consistent * Testing workflow, dry run * Changed bucket variable name * Changed include patterns to lessons directory. Testing workflow, dry run * Modified test date page date to not be a future date. Testing workflow. * updated gitattributes * updated gitattributes, testing workflow * Testing workflow: delete asset * Testing workflow: delete asset * Added production config site parameters, testing branch environment variable * Added parameter to test workflow * Testing workflow with example shortcode * Fixed gitattributes paths * Testing workflow, updated staging paths * Test of git-lfs * Deleted file that should have been tracked with git LFS * Fixed bad path. * Changed action to sync bucket on push to main and to prep for vercel deploy * Added text and image to essence of calculus * Added netlify config file * Changed boolean to string * Pushing arbitrary change to test netlify * Testing netlify preview * Testing netlify preview * Added netlify file config to test CLI * Modified figure shortcode to be aware of page bundle resources. * Test push, added snippets, calculus lesson 1 assets Co-authored-by: Grant Sanderson <grant@3blue1brown.com> Co-authored-by: Josh Pullen <hello@joshuapullen.com> Former-commit-id: 730507cf933e81a52313b7067a47b1f84b5fc339 [formerly 4797018] Former-commit-id: c24f93bc0c866f6e0f99b5ff05bcf5c7710a3766 Former-commit-id: 46ad579 Former-commit-id: 717c7abd32f0d27591db05947fbe4db657afcfbf
This isn't ready to merge, but I'm opening up this pull request to start testing Vercel.
https://3b1b.github.io/3Blue1Brown.com/
in config.