Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essence of Calculus Chapter 1 #58

Merged
merged 15 commits into from
Jun 5, 2021
Merged

Essence of Calculus Chapter 1 #58

merged 15 commits into from
Jun 5, 2021

Conversation

kurtbruns
Copy link
Collaborator

I'm opening this pull request to test Netlify's comment feature and roundtrip the markdownification process. There might be a couple more iterations to do on this lesson.

@netlify
Copy link

netlify bot commented Jun 2, 2021

A reviewer left a comment:

Test comment

Browser metadata
Path:      /lessons/essence-of-calculus/
Browser:   Chrome 90.0.4430.212 on Mac OS 10.15.7
Viewport:  1920 x 978 @1x
Language:  en-US
Cookies:   Enabled

View on BrowserStack

Open Deploy Preview · Mark as Resolved

@kurtbruns
Copy link
Collaborator Author

When writing a question, I think it might make sense to have full markdown support for the question. @3b1b any thoughts on this?

This would make authoring the question a little backwards, but the benefit would be that you could add footnotes, links and images in the question.

Before:

{{<question
  question="What is the height of the rectangle whose left corner touches $r=0.3$? **Note:** This is the rectangle highlighted in the figure above."
  choice1="$6 \pi$"
  choice2="$\frac{3}{10} \pi$"
  choice3="$2 \pi$"
  choice4="$\frac{3}{5} \pi$"
  correct=4
>}}

After:

{{<question
  choice1="$6 \pi$"
  choice2="$\frac{3}{10} \pi$"
  choice3="$2 \pi$"
  choice4="$\frac{3}{5} \pi$"
  correct=4
>}}

What is the height of the rectangle whose left corner touches $r=0.3$? **Note:** This is the rectangle highlighted in the figure above.

{{</question>}}

Alternatively, you could pass the input to the question="..." parameter to the markdownify function.

Here is a screenshot of the example question:

Screen Shot 2021-06-03 at 11 00 46 AM

@3b1b
Copy link
Owner

3b1b commented Jun 3, 2021

This makes a lot of sense to me. @vincerubinetti, would you agree?

@vincerubinetti
Copy link
Collaborator

That's fine with me. Though you may want to save the .Inner for the explanation per #60 . Whichever you think is going to be typically longer. Then use the markdownify on the other.

@3b1b 3b1b merged commit cfb6bc5 into main Jun 5, 2021
@3b1b 3b1b deleted the essence-of-calculus-1 branch June 5, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants