Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable framerate fix for all branches #1189

Closed
wants to merge 351 commits into from
Closed

Variable framerate fix for all branches #1189

wants to merge 351 commits into from

Conversation

qo4on
Copy link

@qo4on qo4on commented Jul 31, 2020

  1. Manim generates variable framerate video instead of the constant value in the CONFIG

  2. mp4fpsmod tool can fix this. Unzip the attachment to manim folder and place this code to line 502 of scene_file_writer.py right after combine_process.wait().

Note: this tool does not work if you have opened the video file in another program.

mp4fpsmod_file_path = os.path.join(
    os.getcwd(),
    'mp4fpsmod.exe' if os.name == 'nt' else 'mp4fpsmod'
)

fix_timestamps_process = subprocess.Popen([
    mp4fpsmod_file_path,
    '--fps', '0:' + str(self.scene.camera.frame_rate),
    '--timescale', '15360',
    movie_file_path, '--inplace'
])
fix_timestamps_process.wait()

mp4fpsmod.zip

3b1b added 27 commits June 28, 2020 10:04
…a proper type as ShaderWrapper. This also includes some cleanup in hos Camera renders
…s a comment just because it's unclear what's best right now
@TonyCrane
Copy link
Collaborator

I think you may have made a mistake, why did you make a pull request from the shaders branch to the master. If you are actually mistaken, please close this pull request.

@qo4on
Copy link
Author

qo4on commented Jul 31, 2020

Yes, sorry.
I made a correct pr.

@qo4on qo4on closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants