-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of SVG transform and Some refactors #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2022
I added a new class |
@3b1b, this pull request is ready to be merged :) |
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ManimGL only supports
matrix(...)
,scale(...)
,translate(...)
transform, and doesn't support multiple transformation in a singletransform
property, which causes many issues.For example
Code:
Result:
This pull request adds full support for all transforms in the svg standard, which are
matrix translate scale rotate skewX skewY
.And refactors the parsing of the name and parameters of each transform by referring to https://github.com/cjlano/svg/blob/3ea3384457c9780fa7d67837c9c5fd4ebc42cb3b/svg/svg.py#L75.
Proposed changes
manimlib/mobject/mobject.py
: allowMobject.scale
receive iterablescale_factor
clip it withmin_scale_factor
manimlib/mobject/svg/svg_mobject.py
: replacewarnings.warn
withlog.warning
manimlib/mobject/svg/svg_mobject.py
: refactorSVGMobject.handle_transforms
and add support forrotate
andskewX skewY
Test
The current performance of the above example
Code:
Result:
rotate
Code:
Result:
skewX
andskewY
Code:
skewX.svg
:skewY.svg
:Result: