Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize getters for ParametricCurve #1757

Merged
merged 1 commit into from Mar 6, 2022
Merged

Conversation

TurkeyBilly
Copy link
Contributor

Motivation

Sometimes a graph is initialized with get_graph method, which stores the function into self.underlying_function attributes. While for function graphs, they are stored in self.function attribute.
Reorganizing getters can help to avoid Attribution error, when trying to initialize another graph that shares the same function with an existing graph.

@TonyCrane TonyCrane requested a review from 3b1b March 6, 2022 09:32
@3b1b 3b1b merged commit dfbbb34 into 3b1b:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants