Refactor LabelledString and relevant classes#1779
Merged
3b1b merged 8 commits into3b1b:masterfrom Apr 6, 2022
YishiMichael:master
Merged
Refactor LabelledString and relevant classes#17793b1b merged 8 commits into3b1b:masterfrom YishiMichael:master
LabelledString and relevant classes#17793b1b merged 8 commits into3b1b:masterfrom
YishiMichael:master
Conversation
TonyCrane
requested changes
Apr 6, 2022
TonyCrane
requested changes
Apr 6, 2022
TonyCrane
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some refactors on
LabelledStringand relevant classes.Proposed changes
manimlib/mobject/numbers.py: Remove the cache dict, sinceSVGMobjects are already cached.manimlib/mobject/svg/labelled_string.py: Support passing insvg_default.colorandsvg_default.fill_coloras aliases ofbase_color; improve algorithm.manimlib/mobject/svg/mtex_mobject.py: Some refactors.manimlib/mobject/svg/text_mobject.py: Some refactors.manimlib/mobject/svg/svg_mobject.py: Add an empty line.