Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LabelledString and relevant classes #1779

Merged
merged 8 commits into from
Apr 6, 2022
Merged

Refactor LabelledString and relevant classes #1779

merged 8 commits into from
Apr 6, 2022

Conversation

YishiMichael
Copy link
Contributor

Motivation

Some refactors on LabelledString and relevant classes.

Proposed changes

  • M manimlib/mobject/numbers.py: Remove the cache dict, since SVGMobjects are already cached.
  • M manimlib/mobject/svg/labelled_string.py: Support passing in svg_default.color and svg_default.fill_color as aliases of base_color; improve algorithm.
  • M manimlib/mobject/svg/mtex_mobject.py: Some refactors.
  • M manimlib/mobject/svg/text_mobject.py: Some refactors.
  • M manimlib/mobject/svg/svg_mobject.py: Add an empty line.

manimlib/mobject/svg/labelled_string.py Outdated Show resolved Hide resolved
manimlib/mobject/svg/labelled_string.py Outdated Show resolved Hide resolved
@TonyCrane TonyCrane requested a review from 3b1b April 6, 2022 15:18
@3b1b 3b1b merged commit 13c731e into 3b1b:master Apr 6, 2022
TonyCrane added a commit that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants