This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
(WIP/Experimental) feat: upgrade orbitdb and ipfs #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe another issue in orbitdb, signature verification for sig by orbitdb key over identity fails. Also when narrowing it down and running keystore.sign and then keystore.verify together with same vals it fails |
|
Ok found issue, yeah verify identity would not work in orbit right now, signing input (identity.id) is a buffer, while input to verify is not a buffer. Making a PR now, could be in orbit-db-identity-provider or probably better in orbit-db-keystore |
|
Closing develop is now using orbit-db@0.21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: orbitdb identity provider is mocked right now, filling in the rest of of it soon
These would be changes for the upgrade to orbitdb 0.20.0 and ipfs 0.34.0. To run it includes the following additional changes and the related dependencies.
Allows migration of old stores to new lib. But entries added in new lib will not be able to be parsed in old lib (hardfork). Can see how we will want to handle that.
Still requires more testing, to see if anything else will require changes with upgrades.