Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customColor error #42

Closed
frankieali opened this issue Jun 2, 2022 · 1 comment
Closed

customColor error #42

frankieali opened this issue Jun 2, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@frankieali
Copy link
Contributor

When switching themes, I'm sometimes seeing "customColor" is not defined or "cannot read property of null (reading 'toArray'). This seems related to setting the customColor on the instanceBuffer. For color based materials, themeColor is set and used by the instanceBuffer. For standard materials, an image texture is used and themeColor is set to null. There seems to be an async disconnect where color materials have null for themeColor and texture materials do not have null for themeColor. Need to find a better way to determine if themeColor is needed by a material instead of forcing the value to null

@frankieali frankieali added the bug Something isn't working label Jun 2, 2022
@frankieali
Copy link
Contributor Author

It took a couple of tried on the demo, but this is the error:
TypeError: Cannot set properties of undefined (setting 'customColor') -> line 49 in Dice.js in the createInstance method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant