-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.0.14 #18
0.0.14 #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jamesmkrieger for the improvement! Is there any difference (in speed or results) when using shlex? I don't like to let the option to use it or not to the user (developer) of the emtable API. I think one should always get the correct results and not think if your table will contain quoted values. What about if we always use shlex for splitting?
Shlex, if used by default, slows down our example tests x10 times |
This is a serious slowdown....anyway might be good to be able to handle these cases without shlex. |
While having quotes as delimiters for the column value is allowed by STAR format, this is the first case I see anybody using them. There are rare cases when relion has "" (empty) values but that's it |
We actually have another case that made me aware of it in our Zernike3D programs. There’s also another case where we’re thinking of using it. I guess there won’t be that many others though. |
Extra kwarg removed, quotes are checked internally now as requested by @delarosatrevin . |
Looks good to me |
One more case covered, when the column value is "ggg ggg" and not " ggg ggg " |
Only check use shlex once and set function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jamesmkrieger and @azazellochg !
Add shlex kwarg for parsing multi-item fields (@jamesmkrieger). False by default as it slow down parsing (e.g. iterRows) by a lot.