Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error exit code #16

Closed
pconesa opened this issue Oct 11, 2022 · 9 comments
Closed

Return error exit code #16

pconesa opened this issue Oct 11, 2022 · 9 comments

Comments

@pconesa
Copy link

pconesa commented Oct 11, 2022

Hi, it's me again. When modelangelo fails it actually does nor return any exit code and therefore programs calling modelangelo fail to detect the error.

Would it be possible to implement this?

Thanks.

@jamaliki
Copy link
Collaborator

Hi,

Yes that is a good idea. It is added now here: 921fdb6

@pconesa
Copy link
Author

pconesa commented Oct 11, 2022

Great! I'll test it and get back here.

@pconesa
Copy link
Author

pconesa commented Oct 11, 2022

Working fine! Thanks!

@pconesa pconesa closed this as completed Oct 11, 2022
@pconesa
Copy link
Author

pconesa commented Nov 7, 2022

Have we lost the exit code in the latest code?

@pconesa pconesa reopened this Nov 7, 2022
@jamaliki
Copy link
Collaborator

jamaliki commented Nov 7, 2022

That shouldn't be the case. Could you give me more details?

@pconesa
Copy link
Author

pconesa commented Nov 7, 2022

After a git pull (I'm using "main" branch) I'm bask to where I when posting this issue.

I remember vaguely you added a sys.exit() call somewhere here but is not there anymore.

https://github.com/3dem/model-angelo/blob/main/model_angelo/apps/build.py#L119

@pconesa
Copy link
Author

pconesa commented Nov 7, 2022

Wait! maybe I'm wrong and my installation is pointing to a old version.. let me check

@jamaliki
Copy link
Collaborator

jamaliki commented Nov 8, 2022

I didn't remove the sys exit, so it should still be the same

@pconesa
Copy link
Author

pconesa commented Nov 8, 2022

Sorry, my installation had an old version without it. After updating it to current main code all works.

@pconesa pconesa closed this as completed Nov 8, 2022
jamaliki added a commit that referenced this issue May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants