Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2D MVP] Milestone 2: Viewer side panel buttons no longer fit small screen sizes #4959

Closed
Tracked by #4833
The-Daniel opened this issue May 10, 2024 · 4 comments
Closed
Tracked by #4833

Comments

@The-Daniel
Copy link
Contributor

The-Daniel commented May 10, 2024

Description

With the addition of the Drawings card the buttons on the left side of the viewer no longer all fit if the user is using a small screen (I get this on my laptop when I have the bookmarks panel open). Perhaps there should be some level of shrink or gap reduction in order to accommodate smaller screens.

  • This is happening in: prod/staging/both
  • This requires a hotfix to production: yes/no

Steps to replicate

  • Open the viewer with a small screen.
  • Ensure the bookmarks panel is also open (Ctrl + Shift + B on Chrome)

Current Behaviour

  • The drawings button is half obscured out of screen

Expected Behaviour

  • All the buttons are visible without the need to zoom out

Pictures/ Gifs of the error

image

Link to design

https://www.figma.com/design/yzsLESycxJwhzw4bqLOS0C/3D-Repo-UI-Components?node-id=901-2438&t=LXM4dd7D1w8Ud1yQ-0

@The-Daniel The-Daniel added the bug label May 10, 2024
@carmenfan
Copy link
Member

carmenfan commented May 10, 2024

The solution here might be to implement the new icon layout in figma
https://www.figma.com/design/wIFHoRuWpJtJv9fMDYrdh7/Enhanced-Image-Support?node-id=0-1&t=hYy97nWwrdtvsmBd-0

It seems to have less padding in between the icons

@carmenfan
Copy link
Member

@sanmont3drepo @AsiteZane i'll put this down for 5.12 as that will become an issue for users when we introduce the additional icon for 2D sheets

@AsiteZane
Copy link

@carmenfan noted thanks - more incentive to remove the first two now :D

@sanmont3drepo sanmont3drepo changed the title Viewer side panel buttons no longer fit small screen sizes [2D MVP] Milestone 2: Viewer side panel buttons no longer fit small screen sizes Jun 4, 2024
Amantini1997 added a commit that referenced this issue Jun 11, 2024
Amantini1997 added a commit that referenced this issue Jun 11, 2024
Amantini1997 added a commit that referenced this issue Jun 11, 2024
Amantini1997 added a commit that referenced this issue Jun 11, 2024
Amantini1997 added a commit that referenced this issue Jun 12, 2024
Amantini1997 added a commit that referenced this issue Jun 12, 2024
Amantini1997 added a commit that referenced this issue Jun 12, 2024
Amantini1997 added a commit that referenced this issue Jun 12, 2024
@carmenfan
Copy link
Member

merged into #4833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants