Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE #3676 - fix test in getCustomLogins.py #3677

Merged
merged 4 commits into from
Nov 1, 2022
Merged

ISSUE #3676 - fix test in getCustomLogins.py #3677

merged 4 commits into from
Nov 1, 2022

Conversation

keifgwinn
Copy link
Contributor

This fixes #3676

Description

  • added test to ensure file exists before operation and safely return nothing to work on if not.

Test cases

  • have a custom login path configured but missing.

@keifgwinn keifgwinn marked this pull request as ready for review October 3, 2022 14:13
This was linked to issues Oct 4, 2022
getCustomLogins script should handle missing config #3676
Closed
GitHub Actions - Link branch to issues #3678
Closed
@keifgwinn keifgwinn removed a link to an issue Oct 4, 2022
GitHub Actions - Link branch to issues #3678
Closed
@keifgwinn keifgwinn linked an issue Oct 4, 2022 that may be closed by this pull request
GitHub Actions - Link branch to issues #3678
Closed
@keifgwinn keifgwinn removed a link to an issue Oct 4, 2022
GitHub Actions - Link branch to issues #3678
Closed
@Charence Charence merged commit 8a18082 into staging Nov 1, 2022
@Charence Charence deleted the ISSUE_3676 branch November 1, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charence Charence Charence approved these changes

Assignees

@Charence Charence

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getCustomLogins script should handle missing config
2 participants
@keifgwinn @Charence