-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 682 - Decommission AssetBundleCreator #685
Conversation
… updated pipeline to use it. Removed the logic that committed the stash graph to the database.
…ests for mesh map reorganiser. Fixed bug in usages array.
… we can use return value of methods with it
…E_682 # Conflicts: # .travis.yml
bouncer/src/repo/manipulator/modelutility/repo_scene_manager.cpp
Outdated
Show resolved
Hide resolved
@sebjf another thing that's missing here (not sure if you're planning to make it a separate ticket) We need to change the bouncerworker so it doens't plonk the task into unityq after completing the work |
…rwise pretend to commit stash to db. updated web buffer commit method to
Hi @carmenfan, done! |
…before trying to generate the stash graph
@carmenfan, ready for another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, just 2 small organising related questions
This fixes #682
Note: anything imported after this merge will require an updated viewer to see: https://github.com/3drepo/3drepounity/pull/534
Description
This PR removes support for
AssetBundleCreator
, and the written stash graph, since that is no longer needed withAssetBundleCreator
gone.This PR predominantly deletes decommissioned parts of the project, but also updates the RepoBundles export to write metadata that .io would have picked up from the stash graph, into the assets list document.
Additionally, the types have been cleaned up.
SupermeshNode
has been introduced as a subclass ofMeshNode
, and all supermesh specific properties are now members of this. The way these nodes are built throughout the code has been refactored to keep as much implementation detail in the factory methods as possible as well, instead of having classes modify the BSON objects themselves with theBSONBuilder
&clone
methods.As part of this, a new class
RepoMeshBSONBuilder
has been added for internal use by the BSON factory, for buildingMeshNode
s andSupermeshNode
s.These changes are "light touch" however, and only done where trivial. The expectation is that big changes will occur in #83, when we know exactly what needs to happen.
For example, though the stash graph is no longer written to disk, its types (i.e. based on
RepoNodeSet
) are still the same, and accessed viaRepoScene
in the same way.MultipartOptimizer
has been refactored so that it no longer creates stash material nodes. This is because since the stash graph is no longer written, there is no longer a need for this indirection. When exporting both textures and materials are now accessed directly from theDefault
graph.The
MeshMapReorganizer
has been given a set of unit tests, and an outstanding bug fixed. After fixing the bug, the RepoBundles exporter has updated how it builds the mappings, and a check in the RepoBundles unit tests has been re-enabled.Finally, the
RepoBundleExport
unit tests have been revised so that they no longer rely on the stash graph.Specifically, this PR:
AssetModelExport
insertBinaryFileToDatabase
SceneManager
so that it no longer writes the stash graph or Unity AssetBundles.CommitStash
testRepoUnityAssets
intoRepoAssets
, and updates the schema to include metadata that would previously have been extracted from the stash graph on-demand.RepoBSONMeshBuilder
object for use by the BSON factory & reduces the direct use of BSON builder objects in the code in favour of factory methodsMultipartOptimizer
unit tests into a common resource for also testingMeshMapReorganizer
MeshMapReorganizer
appendVector3d
method to write a Vector3D as an object instead of an arrayNote, some of these changes are in https://github.com/3drepo/AssetGenerator/issues/3, which must be merged when this PR is.
This issue/PR also addresses:
#678
#683