Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg extrude bevel uses bevelColor instead of color when bevelEnabled is false #504

Closed
kfarr opened this issue Mar 29, 2024 · 2 comments
Closed
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Mar 29, 2024

instead svg extrude bevel should use color instead of bevelColor when bevelEnabled is false

in this example the yield teeth are white (per bevelColor) but should be red (per color)
image

https://3dstreet.app/#/scenes/206e81b2-ef21-403d-98e8-e4103f152a74.json

@Algorush
Copy link
Collaborator

Algorush commented Mar 30, 2024

what if I make the attribute names like this?

  • top element color - topColor
  • main element color - color
  • src for the top element - topSrc
  • src for main - src

I think this names is more logical and more understandable. Is it too late to change now or will it take a long time to redo the attribute names in the current JSON files?

@Algorush
Copy link
Collaborator

Algorush commented Mar 30, 2024

what if I make the attribute names like this?

  • top element color - topColor
  • main element color - color
  • src for the top element - topSrc
  • src for main - src

I have created PR with that change: #505
And also I have changed attr names in yout JSON scene with svg-extruder:
changed-attr.json

I hope you have only one scene with svg-extruder... If not, let me know. I'll change names there too

@kfarr kfarr closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants