Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for dependencies as well, to run firfox in headless mode #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rameshmimit
Copy link

To run firefox in headless mode, it needs firefox-compat package, which is again has some lib dependencies which is been provided by included repo.

@rameshmimit
Copy link
Author

To run firefox in headless mode, it needs firefox-compat package, which is again has some lib dependencies which is been provided by included repo.

@3h4x
Copy link
Owner

3h4x commented Jun 24, 2015

Hiya,
thanks for PR. I can not merge it because it's not OS agnostic.

Please add to dependencies.pp
case $::osfamily {
'RedHat': {
yumrepo { ...

3h4x

@rameshmimit
Copy link
Author

updated my recipe file.(329b2a2)

@3h4x
Copy link
Owner

3h4x commented Jun 24, 2015

Well it's not quite okay because now it will only work on Redhat (fail statement), please fix it.
And then I will test it on docker to see if it's not breaking any other stuff.

@rameshmimit
Copy link
Author

You already written your module for linux only.
validate_re($::kernel, '^Linux$', 'This module will work only on linux. More to come')

@3h4x
Copy link
Owner

3h4x commented Jun 26, 2015

I meant distributuion agnostic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants