Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile with recent boost (clang/gcc) #186

Closed
mpoquet opened this issue Aug 29, 2018 · 2 comments
Closed

Cannot compile with recent boost (clang/gcc) #186

mpoquet opened this issue Aug 29, 2018 · 2 comments

Comments

@mpoquet
Copy link

mpoquet commented Aug 29, 2018

Hello,

I would like to improve the logs of some of my projects and blackhole looks like a very sexy candidate.

Unfortunately, I was not able to compile it on my machine, regardless of the branches and compiler combinations I tried :(. Is something wrong in the way I try to build blackhole?

Build script

#!/usr/bin/env bash
set -eux

rm -rf ./build
mkdir ./build && cd ./build
cmake ..
make

Versions

  • Boost 1.67.0-7
  • gcc 8.2.0-2
  • clang 6.0.1-2

Build logs

master-gcc.log: Looks like boost's API broke =/
master-clang.log: Looks like blackhole's code is not clang-compatible
develop-gcc.log, develop-clang.log: Both compilers have trouble around CHAR_WIDTH = 1;

@3Hren
Copy link
Owner

3Hren commented Aug 30, 2018

Hi!
Seems there is nothing wrong, just compilers and boost because backward incompatible :)

master-clang.log seems easy to fix, however, I currently have no c++ environment configured, so it takes time.

With boost I don't see a way how to fix it except the backward-compatibility can be activated somehow.

Maturin added a commit to Maturin/blackhole that referenced this issue Nov 30, 2018
With boost version 1.66.0 the template parameters of basic_socket were
changed.
@Maturin
Copy link
Contributor

Maturin commented Nov 30, 2018

I created PR #189 with a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants