-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add zk circuits and contracts #3
Conversation
rishotics
commented
Sep 20, 2022
- Add ZK circuit for Hash Check using MiMc hash function and Merkle Tree Inclusion
- Add smart contracts for OTP Validation and Social Recovery
- Add test for both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Should we gitignore the
backend/circuits/HashCeck/build
folder? -
Same for
backend/circuits/OTPVerification/build
-
Another one
backend/typechain-types/
-
Set solidity to latest version?
lastValidatedTimestamp = input[1]; | ||
} | ||
|
||
function verifyOTP( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishotics should we emit Events here to index with theGraph and notify the user/dapp?
emit RecoveryExecuted(old, owner, recoveryRoundNumber); | ||
} | ||
|
||
function cancelRecovery(uint256 recoveryRoundNumber) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
verifier = new Verifier(); | ||
} | ||
|
||
function verifyProofForUserWallet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments would be helpful.