Log system refactor #1822
Merged
Log system refactor #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes to not break the API
laurentj
requested changes
Sep 17, 2020
|
I couldn't find any references to the update/modify/save method in the LWC code, is it present in any external module ? If not, should we delete it ? |
alagroy-42
force-pushed
the
logSystemRefactor
branch
from
db7c2ce
to
c3247c8
Compare
rldhont
approved these changes
Sep 18, 2020
laurentj
requested changes
Sep 29, 2020
laurentj
requested changes
Oct 8, 2020
|
Please fix lint issues showed by checks |
laurentj
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and testing the log classes.