-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding form JSON generator #1842
Conversation
0cfe27a
to
47dc336
Compare
0e9dfcb
to
7dbc43d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you must not store generated files into lizmap directories. Store them into the temp directory.
You should also explain what you're changing into commit messages. I'm not sure what you are doing, since there are too much changes.
7dbc43d
to
14da578
Compare
About the json files storing location, I did a method to get it in AppContext in another PR, so I'll fix it on #1847 to avoid conflicts. Sorry for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will apply request changes
Merged by hand. |
This is the form JSON Generator in
Lizmap\Project\QgisProject
. If you build the app, you will be able to create the JSON and check it. It will be located inlizmap/modules/lizmap/forms/project.layer.form.json
. However, the edition part will not work because of the namespace changing and I didn't modify qgisForm* classes to work with the JSON, it will be for another PR.