Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding form JSON generator #1842

Closed
wants to merge 4 commits into from

Conversation

alagroy-42
Copy link
Contributor

This is the form JSON Generator in Lizmap\Project\QgisProject. If you build the app, you will be able to create the JSON and check it. It will be located in lizmap/modules/lizmap/forms/project.layer.form.json. However, the edition part will not work because of the namespace changing and I didn't modify qgisForm* classes to work with the JSON, it will be for another PR.

Copy link
Collaborator

@laurentj laurentj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must not store generated files into lizmap directories. Store them into the temp directory.

You should also explain what you're changing into commit messages. I'm not sure what you are doing, since there are too much changes.

@alagroy-42
Copy link
Contributor Author

alagroy-42 commented Oct 9, 2020

About the json files storing location, I did a method to get it in AppContext in another PR, so I'll fix it on #1847 to avoid conflicts. Sorry for that.

Copy link
Collaborator

@laurentj laurentj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will apply request changes

lizmap/modules/lizmap/lib/App/JelixContext.php Outdated Show resolved Hide resolved
@laurentj
Copy link
Collaborator

laurentj commented Oct 9, 2020

Merged by hand.

@laurentj laurentj closed this Oct 9, 2020
@alagroy-42 alagroy-42 deleted the FormJSONGeneration branch October 12, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants