[Refactor] Proxy/Request namespace and context #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentj
requested changes
Dec 8, 2020
alagroy-42
force-pushed
the
ProxyRequestRefactor
branch
2 times, most recently
from
b9d5450
to
e509f1b
Compare
laurentj
requested changes
Dec 8, 2020
|
|
||
| protected static $appContext = null; | ||
|
|
||
| public static function setServices($services) |
There was a problem hiding this comment.
Type of parameters is missing (in an @param or directly into the code).
Please document parameters and return values for all new methods.
There was a problem hiding this comment.
the syntax is @param <type> <parameter name>
@param \lizmapServices $services. No two @param for the same parameter.
alagroy-42
force-pushed
the
ProxyRequestRefactor
branch
2 times, most recently
from
54145c2
to
3a5f083
Compare
alagroy-42
force-pushed
the
ProxyRequestRefactor
branch
from
3a5f083
to
0dcc8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1936 with the new files already moved.