-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression : keep atlasprint plugin #4114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The file given to the user is a random string
ts_gkX7a
and the output format extension is missing. Extension is required, using a proper name - The print on the "Montpellier" project http://localhost:8130/index.php/view/map?repository=montpellier&project=montpellier is not printing base layer, is-that correct ?
cfa45f0
to
f3e2840
Compare
Changes done |
The AtlasPrint is not required to run LWC. Pressing the button will lead to a 404 from QGIS server and the button will not work. Possible to use the PHP class |
739e6c8
to
7945b5b
Compare
Changes in the documentation : 3liz/lizmap-documentation#246 Your PR is partially reverting 25ee656, just to keep track for later |
7945b5b
to
4e3e4ed
Compare
QGIS Server does not work atlas print does.
This reverts commit 25ee656.
4e3e4ed
to
88ea45b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better to me
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4114-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6e3b63aac2d9cafed168356c8a67a2a00dc0f6e7,1add07840901cfd139a534000d5ac3492f304bf6,632dbdd6d7af18b23f2715a4a4b8a1704710ad80,16d6796c5a4e8e3be68d95831e66019a6f1cb2dc,88ea45bc908b8e265bec23e8f1e4d4e50ac71277
# Push it to GitHub
git push --set-upstream origin backport-4114-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
Another related commit in the plugin 2c504c0faa86972d1136da16f4dc4a78f6c4a7ee |
QGIS Server does not work atlas print does.