Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content sanitisation in attributes table #4409

Merged
merged 3 commits into from
May 7, 2024

Conversation

nworr
Copy link
Contributor

@nworr nworr commented May 3, 2024

Ticket : #4396

more precision in comment

I completed the cypress test with a check that inline js is cleaned (whole attributes is removed)

Funded by 3Liz

@nworr nworr added run end2end If the PR must run end2end tests or not backport release_3_7 labels May 3, 2024
@github-actions github-actions bot added this to the 3.8.0 milestone May 3, 2024
@nworr nworr marked this pull request as draft May 3, 2024 15:20
@nworr nworr force-pushed the test-attribute-sanitize branch 2 times, most recently from 8dd4f1f to 1c65482 Compare May 6, 2024 07:23
@nworr nworr marked this pull request as ready for review May 6, 2024 08:40
@nworr nworr requested a review from nboisteault May 6, 2024 08:43
Copy link
Member

@nboisteault nboisteault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nworr nworr force-pushed the test-attribute-sanitize branch from 1c65482 to 7ee7068 Compare May 7, 2024 08:48
@nworr nworr merged commit 25eb33d into 3liz:master May 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute table backport release_3_7 run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants