Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check tag with thumbnail class and generate thumbnail #4417

Merged
merged 2 commits into from
May 24, 2024

Conversation

nworr
Copy link
Contributor

@nworr nworr commented May 7, 2024

Since inline js is forbidden the documentation tips to create thumbnail in data table need to be refactored.

I use a dom class and a data attribute that is used to overwrite the src attribute, once datatable has been rendered.

refs #4396

Funded by 3Liz

@github-actions github-actions bot added this to the 3.8.0 milestone May 7, 2024
@nworr nworr added the run end2end If the PR must run end2end tests or not label May 17, 2024
@nworr nworr marked this pull request as ready for review May 21, 2024 08:54
@nworr nworr requested a review from nboisteault May 22, 2024 10:55
@rldhont rldhont added backport release_3_7 javascript Pull requests that update Javascript code attribute table labels May 22, 2024
@rldhont rldhont merged commit b90ddee into 3liz:master May 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute table backport release_3_7 javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants