Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing configs hangs minidsp-rs #421

Closed
conrad-nash opened this issue Jan 13, 2021 · 5 comments
Closed

Clearing configs hangs minidsp-rs #421

conrad-nash opened this issue Jan 13, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@conrad-nash
Copy link

I have BEQd beta 15 installed on a windows 10 machine which is also running minidsp-rs 0.0.3.
minidsp-rs 0.0.3 connects over the network to another 0.0.3 instance running as a service on an rpi3 which is connected to the minidsp 2x4HD.

When executing any function from the Bypass Minidsp dropdown the first time, it works. I can see the server running through all 10 slots and executing a clear.

When running any function as a second try it hangs. It doesn't need to be the same function, clear 1 works, clear 2 has the issue.

I get a response in the minidsp console:

Sent: SetConfig { config: 03, reset: true }
Recv: MaybeConfigChanged

and both apps fail. BEQD spins and eventually times out, minidsp-rs needs to have another command sent to it to respond. Sending another command from another terminal "unlocks" the minidsp service and BEQD gets a checkmark.

I'm not sure if this is a BEQD issue or a minidsp-rs issue.

What I do know is that if I use the all option from a command line I can run it multiple times without any issues.

minidsp --tcp 192.168.86.40:5333 input 0 peq all bypass on

minidsp --tcp 192.168.86.40:5333 input 0 peq all clear

@3ll3d00d
Copy link
Owner

Difficult to see how it is a beqd issue (assuming the command sent is valid), it is basically like

for i in {0..9}
do
    minidsp --tcp 192.168.86.40:5333 input 0 peq ${i} bypass on
done

Use the equivalent for Windows cmd if required

so probably you can test that at the cli and see what happens

@3ll3d00d 3ll3d00d added the question Further information is requested label Jan 13, 2021
@3ll3d00d
Copy link
Owner

I should add a timeout to the CMD though and probably I can use the all option instead too

@3ll3d00d
Copy link
Owner

3ll3d00d commented Jan 14, 2021

noticed I had left some test code in which ignores the return code on a bypass call so perhaps this is related to this (ignoring an error and continuing anyway leaves the minidsp app in some invalid state?)

give beta.16 a try and see if it still happens

3ll3d00d added a commit that referenced this issue Jan 14, 2021
@3ll3d00d 3ll3d00d added bug Something isn't working and removed question Further information is requested labels Jan 14, 2021
@conrad-nash
Copy link
Author

Just tried beta 16 but it behaves the same. I've narrowed it down to the config change and am able to replicate it from a command line, including locally. I'll raise an issue with minidsp-rs

Thanks

@mrene
Copy link

mrene commented Jan 15, 2021

Fixed on my side, was introduced in 0.0.3, fixed in 0.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants