Fix a bug where duplicate objects would be inserted #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact `changes` is an array which may contain duplicates (i.e. multiple objects with the same remoteKey-value), you must make sure to clean `remoteObjectIDs` from duplicates. Otherwise it would propagate the duplicates into `insertedObjectIDs` (which is not a set but an array) which in turn would make the `for loop` over `insertedObjectIDs` insert duplicate objects.
|
I think it makes sense to include this duplicate-handling into DATAFilter, as DATAObjectIDs does away with them the next time you call |
|
@0ff Thanks for pointing this out! |
|
Sounds good! \o/ |
3lvis
added a commit
that referenced
this pull request
Aug 13, 2015
Fix a bug where duplicate objects would be inserted
|
I'll check for another way to fix the duplicated items in changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact
changesis an array which may contain duplicates (i.e. multiple objects with the same remoteKey-value), you must make sure to cleanremoteObjectIDsfrom duplicates.Otherwise it would propagate the duplicates into
insertedObjectIDs(which is not a set but an array) which in turn would make thefor loopoverinsertedObjectIDsinsert duplicate objects.