Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop shipping 'fixture/broken/' to npm #5

Closed
ryan953 opened this issue May 19, 2017 · 2 comments
Closed

Stop shipping 'fixture/broken/' to npm #5

ryan953 opened this issue May 19, 2017 · 2 comments

Comments

@ryan953
Copy link

ryan953 commented May 19, 2017

We need to ignore these files. Test files don't really need to be installed by package consumers, and by default projects with flow enabled will trip up over the broken files in here. It's not a great experience.

@3rd-Eden
Copy link
Owner

3rd-Eden commented May 19, 2017 via email

@ryan953
Copy link
Author

ryan953 commented May 20, 2017

We could definitely suggest something to flow directly. I'm not sure what to ask of them though.

In this case you have an invalid json file (invalid on purpose) that ends up in the node_modules folder.
It makes sense that they find the json files in node_modules, because those files have structure and types. They can be imported into any JS module. So inspecting files and preserving g types makes sense in that case.

So you have a better suggestion, I'll take it over there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants