320159 fixes part 1 #137
Merged
320159 fixes part 1 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are broken sequences like "([^smth])*\s+" or "[^smth]+ *". This prevents abusing those.
Truncate the useragent to 1000 to avoid reject, ref: GUI/uas-parser@c33b124 The check in isSafe for the max length is still there as a safeguard.
|
@3rd-Eden I believe this specific fix is independent from uap-core, is trivial, and could be merged as is =). |
|
@3rd-Eden Is there an expected release date for this fix? |
|
@3rd-Eden Is this fix released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix to lower DoS possibilities. It does not fix all the issues though, but it makes things better and should not break anything.
Ref: https://hackerone.com/reports/320159
Extracted from my private repo.