Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: all long consecutive alphanums are probably evil, not just lowercase #145

Merged
merged 1 commit into from May 23, 2019

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented May 23, 2019

Earlier, all useragents with lowercase alphanum strings of 100 chars without separators were treated as unrecognised for safety (because uap-core regexes are unsafe), but that did not affect uppercase strings.

Timeline:

  • 64b15c9 introduced the original check.
  • b18cf7c added lowercase letters.
  • 687afe4 added spaces and control to probably evil consecutive strings
  • This one adds uppercase letters, i.e. case-insensitive comparison while calculating the consecutive length.

@3rd-Eden 3rd-Eden merged commit 67360c2 into 3rd-Eden:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants