Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change we'll have consistent cropping behavior that follows these rules:
Something of note, the existing
get_global_offsets
function defines the "bounds" of a window to exclude the sign column. This is helpful for placing image inline with text (you don't often want to cover the sign column). But this does mean it's harder to draw over a sign column of a specific window (which is something another plugin might want to do). This is just another thing that we might consider turning into an option inv2.0.0
screen_cap.mp4
Another note. In order to get this behavior I set my
max_height_window_percentage
tomath.huge
. Otherwise it shrinks the image and you can't see the crop happen on resize.This finally (I hope) closes #42
This also fixes the issue where the markdown integration draws images over the status bar, but doesn't prevent an image from being drawn on the status bar if it's not bound to a window