Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Filter photos by face #22

Closed
Me-Mr opened this issue Mar 14, 2024 · 4 comments · Fixed by #26
Closed

Feature: Filter photos by face #22

Me-Mr opened this issue Mar 14, 2024 · 4 comments · Fixed by #26
Assignees

Comments

@Me-Mr
Copy link

Me-Mr commented Mar 14, 2024

Hi! Thanks for the amazing app!

I just wanted to suggest a feature: I think it would be useful to be able to specify faces to only show photos from.

@3rob3
Copy link
Collaborator

3rob3 commented Mar 15, 2024

I have this mostly done, will review with @JW-CH tomorrow.

@Me-Mr
Copy link
Author

Me-Mr commented Mar 15, 2024 via email

@JW-CH
Copy link
Collaborator

JW-CH commented Mar 15, 2024

I have this mostly done, will review with @JW-CH tomorrow.

If you open a PR, I can review it. Note that I am also rebuilding how the calls are made with OpenApi. So we have to test it again :)

3rob3 added a commit that referenced this issue Mar 15, 2024
@JW-CH JW-CH assigned JW-CH and 3rob3 and unassigned JW-CH Mar 16, 2024
@3rob3
Copy link
Collaborator

3rob3 commented Mar 16, 2024

This is done, we just need to figure out the other PR first.

@3rob3 3rob3 linked a pull request Mar 16, 2024 that will close this issue
@JW-CH JW-CH closed this as completed in #26 Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants